sadpandajoe commented on code in PR #44611:
URL: https://github.com/apache/superset/pull/44611#discussion_r4132510694
##########
superset/translations/fa/LC_MESSAGES/messages.po:
##########
@@ -10603,13 +10596,12 @@ msgstr ""
msgid "Modified %s"
msgstr "ویرایش شده %s"
-# Machine-translated via backfill_po.py (claude-sonnet-4-6) [refs: ca, cs, de,
# es, fr, ja, lv, mi, ro, ru, sk, sr, sr_Latn, tr, uk]
-#, fuzzy, python-format
+#, python-format
Review Comment:
Removing the `Machine-translated via backfill_po.py` attribution above only
deleted the first line of the wrapped two-line comment, leaving this
now-meaningless continuation attached to the entry. The same one-line-only
removal repeats for all 97 comment removals in this PR across the touched
catalogs, leaving 97 orphaned reference-list fragments behind. Could this line
(and the equivalent stray line in the other 96 spots) also be deleted?
```suggestion
```
##########
superset/translations/fa/LC_MESSAGES/messages.po:
##########
@@ -10603,13 +10596,12 @@ msgstr ""
msgid "Modified %s"
msgstr "ویرایش شده %s"
-# Machine-translated via backfill_po.py (claude-sonnet-4-6) [refs: ca, cs, de,
# es, fr, ja, lv, mi, ro, ru, sk, sr, sr_Latn, tr, uk]
-#, fuzzy, python-format
+#, python-format
msgid "Modified 1 column in the virtual dataset"
msgid_plural "Modified %s columns in the virtual dataset"
-msgstr[0] "۱ ستون در مجموعه داده مجازی تغییر یافت"
-msgstr[1] "%s ستون در مجموعه داده مجازی تغییر یافت"
+msgstr[0] ""
+msgstr[1] ""
Review Comment:
Clearing this drops a translation whose placeholders actually match: `msgid`
"Modified 1 column in the virtual dataset" carries no placeholder, and the
removed `msgstr[0]` ("۱ ستون در مجموعه داده مجازی تغییر یافت") had none either;
`msgid_plural` "Modified %s columns in the virtual dataset" carries `%s`, and
the removed `msgstr[1]` ("%s ستون در مجموعه داده مجازی تغییر یافت") had it too.
Persian users modifying dataset columns now see the English fallback instead of
a previously-correct translation.
The same pattern shows up at
`superset/translations/zh_TW/LC_MESSAGES/messages.po:1654` ("Added to 1
dashboard", where the removed `msgstr[0]` "增加到看板" also had no placeholder
mismatch). Since the same detection script produced both misses, could you
restore these two entries and recheck the rest of the 52 cleared plural entries
for the same false positive before merging?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
