glaterza commented on code in PR #44611: URL: https://github.com/apache/superset/pull/44611#discussion_r4134069277
########## superset/translations/fa/LC_MESSAGES/messages.po: ########## @@ -10603,13 +10596,12 @@ msgstr "" msgid "Modified %s" msgstr "ویرایش شده %s" -# Machine-translated via backfill_po.py (claude-sonnet-4-6) [refs: ca, cs, de, # es, fr, ja, lv, mi, ro, ru, sk, sr, sr_Latn, tr, uk] -#, fuzzy, python-format +#, python-format Review Comment: You're right, and thanks for spotting it. My comparison checked msgids, headers, locations and extracted comments, but not translator comments, so the stray lines slipped through. Fixed in ff916530bc: 113 continuation lines on 96 entries (some attributions wrapped to three lines). I matched every entry against `master` to remove exactly the lines that continued each attribution there. The comparison now also covers translator comments. It flags all 97 leftovers on the previous head and none on this one. The Persian entry that's restored keeps its attribution, since its translation stays. ########## superset/translations/fa/LC_MESSAGES/messages.po: ########## @@ -10603,13 +10596,12 @@ msgstr "" msgid "Modified %s" msgstr "ویرایش شده %s" -# Machine-translated via backfill_po.py (claude-sonnet-4-6) [refs: ca, cs, de, # es, fr, ja, lv, mi, ro, ru, sk, sr, sr_Latn, tr, uk] -#, fuzzy, python-format +#, python-format msgid "Modified 1 column in the virtual dataset" msgid_plural "Modified %s columns in the virtual dataset" -msgstr[0] "۱ ستون در مجموعه داده مجازی تغییر یافت" -msgstr[1] "%s ستون در مجموعه داده مجازی تغییر یافت" +msgstr[0] "" +msgstr[1] "" Review Comment: Good catch on the Persian entry. It is restored in ff916530bc. Persian's plural rule is `n > 1`, so `msgstr[0]` serves both 0 and 1, and it writes the count as the Persian digit `۱`. The check looked for the value at n=1 and didn't recognise `۱` as it, so it counted the entry as broken at 0 *and* 1. That kept it out of the "fails only at 0" exclusion. The call site only toasts when `columnChanges.modified.length` is non-zero, so the translation is correct in practice. `zh_TW` is different, and I'd keep it cleared. Its header is `nplurals=1; plural=0;`, so `msgstr[0]` "增加到看板" is used for *every* count. "Added to 5 dashboards" renders as "Added to dashboard", with the number gone. That's the "drops a value" case from #44551. I rechecked all 52 cleared plural entries by each language's plural rule (n = 0, 1, 2, 3, 5, 11, 21, 22, 101, 111). Persian was the only one that fails just at n=0. The other 51 each drop the count for some n ≥ 2. The PR is 1,188 entries now; the title and description are updated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
