aipiJuancho commented on PR #44531:
URL: https://github.com/apache/superset/pull/44531#issuecomment-5890356388
Good catch @rusackas — tidied in 5a9f9f3: the vertical test now calls
`fetchMock.removeRoute('vertical-clear-chart-data')` at the end, exactly like
the range-clear test above it.
And the E2E you asked for is in 2f59849: a new scenario in
`playwright/tests/dashboard/clear-all-filters.spec.ts` against the real
backend, reusing that spec's fixture (chart + `birth_names` gender select
filter, vertical bar):
1. select `boy` → Apply, 2. Clear all → Apply, 3. re-select the very value
Clear All removed → **assert Apply becomes enabled again** → Apply reaches the
backend.
That middle assertion is the regression: without the four-line forwarding,
the Select plugin's local state stays pinned to `boy` after Clear all, the
reducer discards the equal-valued re-selection, and Apply stays disabled. Same
flow as the jest regression test, but end-to-end.
`DashboardFilterBar.getApplyButton` became public (one word) so specs can
assert the button state without duplicating the selector.
`jest FilterBar.test.tsx` → 29/29, and the new spec lists cleanly under the
repo's playwright config. PTAL — thanks for testing it locally and for the
quick turnaround.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
