sha174n commented on PR #44080: URL: https://github.com/apache/superset/pull/44080#issuecomment-5891037476
@rusackas all three points you raised are in and unchanged: the omitted-key read in d16ddd8, the non-dataset guard in 5ce70d6, and the `sql` gap in ccb5395. One commit on top in 0fc4493, no behaviour change to any of those. The 422 for a non-string target field was building its detail with an f-string interpolated after `_()`, so only the outer sentence reached the catalog and "must be a string" stayed English everywhere. That outer sentence was also the generic "Dataset schema is invalid" one, which points at the column schema rather than the request body field that failed. It is one msgid now with a `%(field)s` placeholder, and `messages.pot` is regenerated so the string is actually translatable (`check_pot_drift` passes locally). Same pass drops a dict `_requested_target` was building only to read straight back by key, and the existing type-check test now asserts the response names the offending field. 45 unit tests green, pre-commit clean. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
