sha174n commented on PR #44080: URL: https://github.com/apache/superset/pull/44080#issuecomment-5795704261
@rusackas correcting my last CI note: the `messages.pot` drift was not a master-side problem needing its own PR. Master had already regenerated the template in #44574; this branch was just based on the commit before it. Merged master in eadd7831 and all four red checks (`babel-extract`, `check_pot_drift`, and the two gates aggregating it) pass locally. Both points you raised remain in and unchanged: the omitted-key read in d16ddd8, the non-dataset guard in 5ce70d6. One cleanup commit on top in a5aef64, no behaviour change: three mock stubs that set `return_value = None` on calls nobody reads are dropped, and the comment above `requested_table` no longer restates `update_from_object`'s docstring. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
