aminghadersohi commented on PR #44721: URL: https://github.com/apache/superset/pull/44721#issuecomment-5896785225
@rebenitez1802 thanks, all items addressed in 630971d245: - **Column regex (Medium):** the pattern now requires `column` to start the diagnostic and be followed by at most one identifier (Exasol's `column <NAME> not found`), so `object COLUMN not found`, `object MY_COLUMN not found`, `object "column" not found` and `function TO_COLUMN not found` stay generic; each is a test case. Fixed in 630971d245. - **`CONNECTION_DATABASE_PERMISSIONS_ERROR`:** kept, since it is the only engine-level permissions type (the `*_SECURITY_ACCESS_ERROR` types describe Superset's own RBAC) and Databricks already uses it for query-time `INSUFFICIENT_PERMISSIONS`. - **Type annotation:** `custom_errors` is now annotated like the other specs. Fixed in 630971d245. - **Test scaffolding:** the manual Flask/Babel setup is removed in favour of the shared `app_context` fixture. Fixed in 630971d245. - **Title nit:** the title now reads "classify common server errors", and the description notes that a leading driver/SQLSTATE wrapper is dropped while trailing position text is kept. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
