aminghadersohi commented on PR #44721: URL: https://github.com/apache/superset/pull/44721#issuecomment-5903804228
@rebenitez1802 your round-2 review is addressed in the code: - **🔴 Patterns matching inside echoed SQL (`exa+websocket`), fixed in 02262dbd9f.** `ExasolEngineSpec._extract_error_message` drops the `query =>`, `[SQL:` and `[parameters:` tails before matching, then keeps only PyExasol's `message =>` field. `test_extract_errors_ignores_echoed_sql` feeds verbose, multi-line, PyExasol-shaped messages whose SQL contains each pattern (including your `SELECT 'syntax error' FROM P` example), plus `StatementError` wrappers. - **🟢 Quoted qualified column names, fixed in 02262dbd9f.** The column pattern uses the `part(.part)*` grammar. `column "T"."C" not found`, the mixed forms and the unquoted dotted forms are test cases, and the `object COLUMN` and `function TO_COLUMN` near-misses still stay generic. > **bito, "Multiline diagnostic truncation":** the second `re.split` truncates at the first line that looks like `word =>`. Valid for a continuation line that starts with `word =>`. Fixed in 487202a2b0: the message field now ends only at the envelope fields PyExasol 2.4.1 prints (`dsn`, `user`, `schema`, `session_id`, `code`, `query`, taken from `ExaError`, `ExaRequestError` and `ExaQueryError.get_params_for_print`). `test_extract_verbose_diagnostic_keeps_arrow_lines` uses a full envelope whose diagnostic includes a `hint => ...` line. It fails on 02262dbd9f and passes on 487202a2b0. The example given, `column X => Y not found`, was never truncated, because the old split only matched a single word at the start of a line. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
