bito-code-review[bot] commented on PR #44713: URL: https://github.com/apache/superset/pull/44713#issuecomment-5897200235
<!-- Bito Reply --> The concern regarding the dependency on `elasticsearch-dbapi` version 0.2.14 is valid, as the current implementation in this PR relies on types that may not be correctly mapped in older versions. Since the PR introduces `FIELD_TYPE_MAPPINGS` to handle types like `byte`, `short`, `scaled_float`, `unsigned_long`, and `half_float`, it is appropriate to either update the dependency requirements or explicitly document this dependency in the PR description to ensure users are aware of the necessary version for these changes to take effect. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
