aminghadersohi commented on code in PR #44713:
URL: https://github.com/apache/superset/pull/44713#discussion_r4140687020
##########
superset/db_engine_specs/elasticsearch.py:
##########
@@ -31,12 +31,34 @@
SupersetDBAPIOperationalError,
SupersetDBAPIProgrammingError,
)
+from superset.utils.core import GenericDataType
if TYPE_CHECKING:
from superset.models.core import Database
logger = logging.getLogger()
+# Elasticsearch/OpenSearch field types that the default column type mappings
+# do not recognize. DOUBLE, FLOAT, INTEGER, LONG, BOOLEAN and DATETIME are
+# already covered by the defaults.
+FIELD_TYPE_MAPPINGS = (
Review Comment:
Agreed that this depends on preset-io/elasticsearch-dbapi#126. It's merged,
but 0.2.14 isn't on PyPI yet (latest is 0.2.13), so there's nothing to bump
`requirements/*.txt` or the pyproject floor to. I've updated the description to
state the dependency and that the change has no user-visible effect on 0.2.13.
The mappings are harmless ahead of the release, and I'll bump the pin as soon
as 0.2.14 is published. Leaving this open until then.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
