mikebridge opened a new pull request, #44806: URL: https://github.com/apache/superset/pull/44806
### SUMMARY - Enable Ordering in Table **Raw records** mode for semantic views using only dimensions selected in Columns. - Drop a saved sort when its dimension is removed, because MetricFlow rejects ordering by an item absent from the query. - Leave ordinary dataset ordering and the provider compatibility contract unchanged. This is a focused first cut for [SC-123363](https://app.shortcut.com/preset/story/123363). It does **not** address the separate no-metric, two-hop artist-dimension resolution failure. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF Not attached; manual UI verification is included below. ### TESTING INSTRUCTIONS 1. With `SEMANTIC_LAYERS` enabled, open a semantic-view Table chart in **Raw records** mode. 2. Select `scrobble__played_at` and `song__song_name`. Confirm Ordering offers ascending/descending choices for those columns and no unselected dimensions. 3. Sort descending by played-at and run the chart. Remove played-at from Columns and run again; the stale sort must not be sent. 4. Open an ordinary dataset Table and confirm its ordering choices are unchanged. Local checks: all Table plugin Jest tests passed (10 suites, 177 tests); staged-file `pre-commit run` passed, including targeted frontend type-checking. A local MetricFlow CLI query accepted ordering by selected dimensions and rejected ordering by an unselected dimension. The repository-wide `npm run type` did **not** pass locally: TS6305 reported missing generated `.d.ts` files in unrelated packages after the master refresh. The full frontend build and deployed dbt Cloud/browser pass were not run; please use CI and manual review for those gates. ### ADDITIONAL INFORMATION - [x] Has associated issue: [SC-123363](https://app.shortcut.com/preset/story/123363) - [x] Required feature flags: `SEMANTIC_LAYERS` - [x] Changes UI - [ ] Includes DB Migration - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
