codeant-ai-for-open-source[bot] commented on code in PR #44807:
URL: https://github.com/apache/superset/pull/44807#discussion_r4139192558
##########
superset-frontend/packages/superset-ui-core/src/components/Table/VirtualTable.tsx:
##########
@@ -183,6 +183,12 @@ const VirtualTable = <RecordType extends object>(
(lastColumn.width as number) + Math.floor(tableWidth - totalWidth);
}
+ // Size the antd header to the Grid's columns, not a viewport-wide scroll.x.
+ const columnsWidth = mergedColumns.reduce(
+ (sum, column) => sum + ((column.width as number) || 0),
+ 0,
+ );
+
Review Comment:
✅ **CodeAnt verified this suggestion was addressed in subsequent commits and
marked this thread resolved** as of `d339a4e`.
`columnsWidth` now sums only widths whose values are numbers, treating
string widths such as percentages as zero instead of concatenating them into an
invalid value.
<sub>If that's not right, unresolve this thread and CodeAnt will leave it
open.</sub>
<!-- codeant-auto-resolve-reply -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
