aminghadersohi opened a new pull request, #44796: URL: https://github.com/apache/superset/pull/44796
### SUMMARY Require a truthy `WEBSOCKET_ENABLE` before publishing a dashboard filter notification. When websockets are disabled or unset, the MCP tool still returns the dashboard permalink but reports `live_update_pushed: false` and does not publish. Gate location: `_publish_filters_applied`, not `publish_realtime`. A repository-wide caller search found the dashboard tool and TaskManager's wrapper (used by entity-change and task-status notifications). The task publishers have an independent coordination-backend-based contract and an initialized channel override. Keeping the gate in the dashboard tool fixes its response without changing those legacy task publishers. Update the MCP documentation and parameterize regression coverage for enabled, disabled, and unset websocket configuration, alongside missing-backend and publish-failure cases. Existing guest routing coverage explicitly enables websockets. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF Not applicable; backend notification behavior only. ### TESTING INSTRUCTIONS - `PYTHONPATH=.:superset-core/src pytest -q tests/unit_tests/mcp_service/dashboard/tool/test_apply_dashboard_filters.py tests/unit_tests/test_realtime_publish.py` - `pre-commit run` on the three explicitly staged files, including mypy. - `PYTHONPATH=.:superset-core/src pylint --rcfile=.pylintrc --load-plugins=superset.extensions.pylint --reports=no superset/mcp_service/dashboard/tool/apply_dashboard_filters.py` - With a coordination backend configured, call `apply_dashboard_filters` with websockets disabled: verify that no notification is published, `live_update_pushed` is false, and the permalink is returned. Enable websockets and repeat with an authenticated principal: a successful publish reports true. ### ADDITIONAL INFORMATION - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
