bito-code-review[bot] commented on code in PR #44351:
URL: https://github.com/apache/superset/pull/44351#discussion_r4139982112
##########
tests/unit_tests/mcp_service/chart/tool/test_get_chart_sql.py:
##########
@@ -1208,6 +1208,14 @@ def mock_auth(self):
mock_get_user.return_value = mock_user
yield mock_get_user
+ @pytest.fixture(autouse=True)
+ def mock_db_refresh(self):
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Fixture missing return type</b></div>
<div id="fix">
The new `mock_db_refresh` fixture lacks a return type annotation, which the
repo's typing convention mandates for all fixtures, including their return
types (BITO.md rules 11810/12490). Annotate it `-> Iterator[None]` (yield-based
fixture) plus the `Iterator` import. Sibling `mock_auth` has the same gap but
is unchanged code here.
</div>
</div>
<small><i>Code Review Run #d8518b</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
