aminghadersohi commented on PR #44723: URL: https://github.com/apache/superset/pull/44723#issuecomment-5903827837
Following up on the two additional suggestions in Bito run #90bdb8, fixed in d647235ba1: - **Inconsistent output variable name:** the SSL tests that bound the returned dict as `result` now use `connect_args`, the parameter name in `adjust_engine_params`. - **Missing test docstring:** `test_ssl_request_rejects_url_ssl_disabled` now documents that a truthy URL `ssl_disabled` conflicts with the SSL request. `test_pymysql_hostname_verification_survives` and `test_pymysql_unsupported_ssl_options_fail_closed`, also added in this PR, got docstrings too. `tests/unit_tests/db_engine_specs/test_mysql.py`: 143 passed. This is a test-only change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
