aminghadersohi commented on PR #44718: URL: https://github.com/apache/superset/pull/44718#issuecomment-5903851924
Following up on the additional suggestions in Bito runs #a18ea6 and #a678d1: **#a18ea6** - **Missing docstrings:** `test_extract_errors` and `test_build_sqlalchemy_uri` already had them. `test_get_column_spec_extra_types` and `test_quarter_time_grain_avoids_interval_quarter` get them in cc8c89e347. - **Inline imports:** not changed. Every test in `test_doris.py` that uses `DorisEngineSpec` imports it inside the function, and so do the other `tests/unit_tests/db_engine_specs` modules. The new tests follow that pattern. Hoisting only the new ones would mix two styles in one file. - **Test depends on app config:** fixed in cc8c89e347. The quarter-grain test reads `DorisEngineSpec._time_grain_expressions[TimeGrain.QUARTER]`, so `TIME_GRAIN_DENYLIST` and `TIME_GRAIN_ADDON_EXPRESSIONS` can't change it. - **`build_sqlalchemy_uri` docstring:** already present at head. **#a678d1** - **Missing test docstrings:** fixed in cc8c89e347 for `test_mysqlclient_ssl_request_drops_false_ssl_disabled`, `test_mariadb_tls_request_cannot_be_cancelled`, `test_mariadb_pymysql_tls_request_requires_verification` and `test_unrequested_mariadb_connection_unchanged`. That commit also covers the three MySQL SSL tests that still lacked one, and the SSL tests now name the returned dict `connect_args`. Doris, MySQL and MariaDB unit suites: 193 passed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
