aminghadersohi commented on PR #44718: URL: https://github.com/apache/superset/pull/44718#issuecomment-5884576752
Confirmed every ask in the three review bodies flagged by the gate. #473e5d: TLS round-trip and all six docstrings are fixed in d14f65bd1a; query loss is disproved by test_doris_tls_preserves_uri_query. #5e217e: shared constants are fixed in 03306ebaf0; heading and independent query.ssl_mode handling are fixed in e781d327b9. #b882ae: the assertions intentionally straddle build_sqlalchemy_uri to detect input mutation, so they are not redundant. All CI checks pass. The gate still flags the historical bodies and missing approval. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
