hainenber commented on code in PR #44699:
URL: https://github.com/apache/superset/pull/44699#discussion_r4143878940
##########
.github/workflows/codeql-analysis.yml:
##########
@@ -56,7 +70,7 @@ jobs:
strategy:
fail-fast: false
matrix:
- language: ["python", "javascript"]
+ language: ${{ fromJson(needs.changes.outputs.lang_matrix) }}
Review Comment:
Oh if that's the case then it's quite a glaring issue with existing
`change_detector.py` logic. No doubt that should be fixed but IMO, it's a bit
scope-creeping if we include the changes here. I've created
https://github.com/apache/superset/issues/44822 for tracking
##########
.github/workflows/codeql-analysis.yml:
##########
@@ -56,7 +69,7 @@ jobs:
strategy:
fail-fast: false
matrix:
- language: ["python", "javascript"]
+ language: ${{ fromJson(needs.changes.outputs.lang_matrix) }}
Review Comment:
Created https://github.com/apache/superset/issues/44822 for tracking
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
