sadpandajoe commented on code in PR #44699:
URL: https://github.com/apache/superset/pull/44699#discussion_r4154471551
##########
.github/workflows/codeql-analysis.yml:
##########
@@ -56,7 +69,7 @@ jobs:
strategy:
fail-fast: false
matrix:
- language: ["python", "javascript"]
+ language: ${{ fromJson(needs.changes.outputs.lang_matrix) }}
Review Comment:
Tracking this in a follow-up still leaves JavaScript changes outside
`superset-frontend/` without a JavaScript scan after this merges. Could we keep
both languages in the matrix until the detector can classify those files
correctly?
##########
.github/workflows/codeql-analysis.yml:
##########
@@ -56,7 +70,7 @@ jobs:
strategy:
fail-fast: false
matrix:
- language: ["python", "javascript"]
+ language: ${{ fromJson(needs.changes.outputs.lang_matrix) }}
Review Comment:
The detector bug predates this PR, but using its output to drop a language
scan and removing the scheduled fallback makes it a coverage regression here.
Could we retain the full language matrix or the scheduled full scan until the
push-range fix lands?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
