aminghadersohi commented on PR #44148: URL: https://github.com/apache/superset/pull/44148#issuecomment-5914056718
@rebenitez1802 Both follow-up nits are fixed in f02ab1d232aPLACEHOLDER: - Nit 1: saved and unsaved Vega-Lite previews use one shared empty-result gate that honors `allows_empty_result`, with unsaved-path regression coverage. - Nit 2: replaced the tautological Treemap case with a generic bar case that fails without the gate. Validation: 662 affected unit tests passed; pre-commit passed, including mypy and ruff. Disabling the shared gate makes all six non-Gantt regression cases fail; both Gantt cases still pass. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
