aminghadersohi commented on PR #44148: URL: https://github.com/apache/superset/pull/44148#issuecomment-5901581114
Follow-up on the bito run #1ac576 "Additional Suggestions" (09-29): - **Country map: silent metric row drop** (`transformProps.ts`): the comment is fixed in 6bc655e038. Omitting rows with a non-finite metric is intentional (@rusackas asked for sparse metrics to render blank instead of failing the chart). The comment now says that such rows are left out of the rendered data, so their region stays unshaded. Region identifiers are still validated for every row. Those blank regions now cross-filter and drill on their original source value. - **Scatter: mixed concerns**: fixed in af5a06246a. Coordinate and radius validation moved into the exported helper `filterDrawableGeographicPoints`, which has its own test. - **Scatter: silent row drop**: fixed in af5a06246a. The helper logs `Skipped N of M geographic points …` through `logging.warn`, and the MCP guide documents the behavior. Throwing is deliberately not restored, per the same maintainer request. - **World map: redundant `exactNames`**: not changed. The map isn't redundant. `exactNames` is a case- and accent-sensitive exact lookup that runs first. The folded lookup holds a *list* per key and only accepts a unique match. If two names ever fold to the same key, an exact spelling still resolves through `exactNames` while the folded lookup would reject it as ambiguous. This matches the backend's exact-first rule in `resolve_geographic_value`. - **World map: dead `name` lookup map**: fixed in af5a06246a. `lookups` now covers only the code fields (`cca2`, `cca3`, `cioc`). Names resolve only through `exactNames`/`foldedNames`. @sadpandajoe's 09-29 review threads (compact discovery schema docs, world-map diacritic folding, name-only folding in `normalizeRegions`, disabled-type conversion in `update_chart`) were fixed in 3aac5ab210 and resolved with evidence replies. Nothing further is outstanding there. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
