sadpandajoe commented on code in PR #44101:
URL: https://github.com/apache/superset/pull/44101#discussion_r4147884649
##########
superset-frontend/src/views/routePaths.ts:
##########
@@ -57,4 +57,5 @@ export const RoutePaths = {
USERS: '/users/',
GROUPS: '/list_groups/',
EXTENSIONS: '/extensions/list/',
+ EXTENSION_VIEW: '/extensions/view/:viewId',
Review Comment:
The Flask host route accepts `<path:view_id>`, but this client route's
`:viewId` only matches one path segment. For a registered view id that contains
a `/` (for example `my-ext/settings`), a direct load gets the app shell and the
view never resolves. Should the two routes share one id grammar, either by
restricting/encoding view ids or by accepting multiple segments here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
