rusackas commented on code in PR #44101:
URL: https://github.com/apache/superset/pull/44101#discussion_r4154928628
##########
superset/views/core.py:
##########
@@ -797,6 +797,34 @@ def file_handler(self) -> FlaskResponse:
return self.render_app_template(extra_bootstrap_data=payload)
+ @has_access
Review Comment:
Went with the `welcome` pattern and dropped `@has_access`, since `view_id`
is never used server-side and role sync wont backfill `can_extension_view` onto
existing roles anyway. Added a Gamma-user regression test for it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
