sadpandajoe commented on code in PR #44243: URL: https://github.com/apache/superset/pull/44243#discussion_r4147911973
########## docs/admin_docs/configuration/alerts-reports.mdx: ########## @@ -538,11 +530,22 @@ omitted. Cookies, authentication headers, URLs, SQL, and query payloads are not included in these transport diagnostics. HTTP 400 therefore remains a failure to investigate, not a reason to repeat the same request. -### Check web browser and webdriver installation +### Check the Playwright and Chromium installation + +To take a screenshot, the worker visits the dashboard or chart using a headless Chromium browser controlled by Playwright, then takes a screenshot. If you are able to send a chart as CSV, XLSX, or text but can't send as PNG, your problem may lie with the browser. When Playwright or Chromium is missing or fails to launch, screenshot attempts fail with an error that includes `Playwright is required for screenshots`. Review Comment: This error string doesn't match what the code raises. A launch failure (e.g. Chromium missing) raises `Failed to launch the headless browser for screenshots`; `Playwright is required for screenshots` is raised only when the Playwright package itself can't be imported. An operator troubleshooting a missing/broken Chromium install would search for the documented string and not find it. Could this quote the actual launch-failure message instead, and keep `Playwright is required for screenshots` scoped to the import-failure case it's tied to? ########## docs/admin_docs/configuration/dashboard-performance.mdx: ########## @@ -174,7 +174,7 @@ scheduled table in the warehouse so each chart query is a cheap lookup. - See [Feature Flags](./feature-flags.mdx) for the full list of supported flags and their lifecycle stages. - Server-side screenshot jobs (alerts, scheduled reports, thumbnails) - render the dashboard in a headless, webdriver-controlled browser, which + render the dashboard in a headless Chromium browser driven by Playwright, which intentionally bypasses row virtualization so the rendered artifact includes every chart, not just the ones above the fold. User-triggered Review Comment: Agreed—a dashboard's inactive tabs aren't rendered when the screenshot job runs, so their charts are left out of the captured image; the claim that the screenshot includes every chart isn't accurate for multi-tab dashboards. Could this line note that only the active tab's charts are captured? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
