sadpandajoe commented on code in PR #44243: URL: https://github.com/apache/superset/pull/44243#discussion_r4148871668
########## docs/admin_docs/configuration/alerts-reports.mdx: ########## @@ -50,13 +50,10 @@ Screenshots will be taken but no messages actually sent as long as `ALERT_REPORT #### In your `Dockerfile` -You'll need to extend the Superset image to include a headless browser. Your options include: +As of 7.0.0, Superset takes screenshots only with [Playwright](https://playwright.dev/python/) driving a headless Chromium browser. Selenium, Firefox, geckodriver and the `WEBDRIVER_TYPE` setting are not supported, and no feature flag is needed to use Playwright. Prior to 7.0.0, users were responisble for installing their own headless browser, and could use Selenium if desired. -- Use Playwright with Chromium: this is the recommended approach as of version 4.1.x or greater. Playwright always uses Chromium — the `WEBDRIVER_TYPE` config setting has no effect when Playwright is active. A working example of a Dockerfile that installs these tools is provided under "Building your own production Docker image" on the [Docker Builds](/admin-docs/installation/docker-builds#building-your-own-production-docker-image) page. Enable the `PLAYWRIGHT_REPORTS_AND_THUMBNAILS` feature flag in your config to activate it. -- Use Firefox (Selenium): you'll need to install geckodriver and Firefox. Set `WEBDRIVER_TYPE` to `"firefox"` in your `superset_config.py`. -- Use Chrome (Selenium): you'll need to install Chrome. Set `WEBDRIVER_TYPE` to `"chrome"` in your `superset_config.py`. - -In Superset versions <=4.0x, users installed Firefox or Chrome and that was documented here. +- The default Superset image (for example the `latest` and `<version>` tags) includes Playwright and Chromium. +- The `lean` image and custom images need them installed. A working example of a Dockerfile that installs these tools is provided under "Building your own production Docker image" on the [Docker Builds](/admin-docs/installation/docker-builds#building-your-own-production-docker-image) page. Review Comment: As of the current head, the linked Docker Builds page (docs/admin_docs/installation/docker-builds.mdx) still tells readers to enable the removed `PLAYWRIGHT_REPORTS_AND_THUMBNAILS` flag and offers Selenium as an alternative, and still describes `-dev` as including a browser — so a reader following this section's link lands on contradictory, stale instructions. Since #44240 doesn't appear to have landed yet, should this PR wait to merge alongside #44240, or should the link here be qualified in the meantime? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
