aminghadersohi commented on code in PR #44452:
URL: https://github.com/apache/superset/pull/44452#discussion_r4149212505
##########
superset-frontend/plugins/plugin-chart-table/src/controlPanel.tsx:
##########
@@ -60,6 +60,20 @@ import { GenericDataType } from
'@apache-superset/core/common';
import { isEmpty, last } from 'lodash-es';
import { PAGE_SIZE_OPTIONS, SERVER_PAGE_SIZE_OPTIONS } from './consts';
+function isServerPaginationUnsupported({
Review Comment:
Verified the approval's AG Grid question: ag-grid-table's
`server_pagination`/`server_page_length` (controlPanel.tsx:384,397) are ungated
and its buildQuery emits `row_offset` (:249,271), so with
`AG_GRID_TABLE_ENABLED` the same provider error is reachable. Share this
helper, or note the deferral?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
