mikebridge commented on code in PR #44452:
URL: https://github.com/apache/superset/pull/44452#discussion_r4149740693
##########
superset-frontend/plugins/plugin-chart-table/src/controlPanel.tsx:
##########
@@ -60,6 +60,20 @@ import { GenericDataType } from
'@apache-superset/core/common';
import { isEmpty, last } from 'lodash-es';
import { PAGE_SIZE_OPTIONS, SERVER_PAGE_SIZE_OPTIONS } from './consts';
+function isServerPaginationUnsupported({
Review Comment:
Good catch. AG Grid had the same offset-producing path. I shared Table's
capability check and made AG Grid's pagination controls fail closed when
`ROW_OFFSET` is absent, while keeping the saved value and the explicit reset:
[27709410](https://github.com/apache/superset/commit/277094100e3ea998de7f35837e1dc13332ac5cd4).
The new AG Grid control test failed in six cases before the fix and passes now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
