aminghadersohi commented on code in PR #44856:
URL: https://github.com/apache/superset/pull/44856#discussion_r4152025924
##########
superset-frontend/playwright/tests/mobile/mobile-dashboard.spec.ts:
##########
@@ -35,25 +35,10 @@ import { URL } from '../../utils/urls';
// Use iPhone 12 viewport for mobile tests
const mobileViewport = devices['iPhone 12'];
-/**
- * Navigates to the dashboard list, clicks the first available dashboard
- * card, and waits for navigation into that dashboard. Skips the current
- * test when no dashboards are available to open.
- */
-async function openFirstDashboard(page: Page): Promise<void> {
- await page.goto(URL.DASHBOARD_LIST);
+/** Opens the sample dashboard with charts, independently of dashboard list
order. */
+async function openExampleDashboard(page: Page): Promise<void> {
+ await page.goto('dashboard/world_health/');
Review Comment:
Fixed in cf55144f6a1d957891c3f5676c737d7f1ae092f2: openExampleDashboard
skips on a 404 with a clear missing-fixture reason; filter tests reuse the same
guard. CI loads examples, but individual loader failures can leave world_health
absent. Formatting and lint passed; custom rules, stylelint, and type checking
were blocked by missing frontend dependencies. E2E was not run because the
local Superset server is unavailable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
