aminghadersohi commented on PR #44856: URL: https://github.com/apache/superset/pull/44856#issuecomment-5940654229
@rebenitez1802 addressed: 1. Removed the pagination branch → 47bdb0a1d6; strict-prefix, exact-only selection in the shared SaveChartModal helper, used by both Explore specs → a0fb1a4003. 2. Post-PUT duplicate-count guard → 47bdb0a1d6; target dashboard-id assertions on PUT bodies → a0fb1a4003. 3. Deleted the stale mobile interaction beforeAll → a0fb1a4003. 4. gotoWithRetry + HTTP 200 + missing-fixture message → a0fb1a4003. 5. Corrected “World Bank's Data” comments → a0fb1a4003; corrected the PR summary, preserving the rest of the body. 6. Consolidated on master's existing shared helper → 47bdb0a1d6 + a0fb1a4003; no other PR changed. 7. AsyncSelect remains untouched and out of scope → a0fb1a4003. Master merged and conflict cleared → 47bdb0a1d6. Validation: ESLint, formatting, oxlint, custom rules, stylelint and whitespace passed; isolated helper/mobile typecheck passed; all 11 tests collected. Full typecheck/pre-commit type hook blocked by missing frontend dependencies/unbuilt packages (no playwright tsconfig). E2E not run: no local Superset. No environment started. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
