sadpandajoe commented on code in PR #44397:
URL: https://github.com/apache/superset/pull/44397#discussion_r4154267440
##########
superset-frontend/src/pages/DatabaseList/index.tsx:
##########
@@ -747,6 +747,8 @@ function DatabaseList({
},
{
accessor: 'backend',
+ // i18n: the database engine behind a connection (PostgreSQL, MySQL),
Review Comment:
With `SEMANTIC_LAYERS` enabled, this column also displays semantic-layer
type names from `_serialize_semantic_layer()`, not just database engines, so
this context can steer translators toward a database-only label. Could the note
cover both connection types?
##########
scripts/translations/backfill_po.py:
##########
@@ -594,6 +643,8 @@ def _build_batch_items(
"index_key": entry.msgid,
"is_plural": False,
}
+ if note := _developer_note(entry):
Review Comment:
A note such as `i18n: translate Slug as a URL identifier; do not translate
as an animal` is matched by `_is_do_not_translate()` and removes the
untranslated entry before this note reaches either translation path. Could
disambiguation prose be kept distinct from an actual do-not-translate marker?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
