glaterza commented on code in PR #44397:
URL: https://github.com/apache/superset/pull/44397#discussion_r4159028462
##########
superset-frontend/src/pages/DatabaseList/index.tsx:
##########
@@ -747,6 +747,8 @@ function DatabaseList({
},
{
accessor: 'backend',
+ // i18n: the database engine behind a connection (PostgreSQL, MySQL),
Review Comment:
Good catch. `DatabaseList` is the only `t('Backend')` call site, so one note
has to cover both connection types. Reworded in 4bbce5afc3 to:
> the kind of system behind a connection: a database engine (PostgreSQL,
MySQL) or a semantic layer; not a server tier or a driver
The template and all 30 catalogs carry the new wording. As before, I checked
it against `pybabel update` with the script's flags on a copy: all 120 noted
entries come out identical. The drift check fails with `~ 'Backend'` if the
source comment and the template disagree. The howtos example uses the new
wording too:
<img width="860" height="597" alt="The howtos section Adding context for
translators, rendered locally, showing the reworded Backend example"
src="https://github.com/user-attachments/assets/d9c8ed2c-f4fd-4b32-9c82-d2947c05b59b";
/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
