nicob3y commented on code in PR #35662:
URL: https://github.com/apache/superset/pull/35662#discussion_r4154061981


##########
docs/admin_docs/configuration/sql-templating.mdx:
##########
@@ -556,14 +556,23 @@ WHERE
 
 It's possible to query physical and virtual datasets using the `dataset` 
macro. This is useful if you've defined computed columns and metrics on your 
datasets, and want to reuse the definition in adhoc SQL Lab queries.
 
-To use the macro, first you need to find the ID of the dataset. This can be 
done by going to the view showing all the datasets, hovering over the dataset 
you're interested in, and looking at its URL. For example, if the URL for a 
dataset is 
https://superset.example.org/explore/?dataset_type=table&dataset_id=42 its ID 
is 42.
+To use the macro, you can reference the dataset either by its numeric ID or by 
its name.
+
+- By ID: you need to find the dataset's ID. This can be done by going to the 
view showing all the datasets, hovering over the dataset you're interested in, 
and looking at its URL. For example, if the URL for a dataset is 
https://superset.example.org/explore/?dataset_type=table&dataset_id=42 its ID 
is 42.
+- By name: just pass the dataset’s exact name

Review Comment:
   Doc updated



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to