rusackas commented on PR #35662: URL: https://github.com/apache/superset/pull/35662#issuecomment-5972372845
Thanks @nicob3y, the name lookup and alias are shaping up nicely. A few of @sadpandajoe's threads are still open and I'd love another pass on those before this gets merged: the second `dbs` join that breaks `database_id="examples"` for restricted users, the `from_dttm`/`to_dttm` args that get accepted but dropped (forward them or remove them for now), and an integration test that exercises the access filter as a Gamma + SQL Lab user rather than mocking the whole DAO. Holler if you want a hand with any of it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
