mikebridge commented on PR #44028: URL: https://github.com/apache/superset/pull/44028#issuecomment-5934909649
Thanks for identifying both cases. Addressed in `751be2b010c0677bf6f47139fd4110e5c12c89dc`, which also merges master `b98e19f6eb23784db5d874346b4a14dd36eb786d`. Chart IDs are now normalized and written back before layout repair. Detached duplicates are deduplicated while they still carry CHART identity; only remaining absent references become placeholders. The stored integer IDs are then available to both native and cross-filter scope readers. Red-first tests exercise both `position_json` and `json_metadata.positions`, including string/integral-float IDs, SQL readback, and both scope readers. One deliberate legacy-slot distinction: a detached slot with a null or missing chart ID has no identity to deduplicate. This retains it as a placeholder in a reachable row, preserving its size; master previously dropped it. The existing null-slot save behavior remains supported, and the docs explicitly describe reattachment rather than claiming its detached position survives. The final focused suite has 115 passing tests, branch hooks pass, and the exact pushed tree received independent review. The PR remains draft; this is a status update on the two fixes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
