drivaspreset commented on code in PR #43004:
URL: https://github.com/apache/superset/pull/43004#discussion_r4158974254
##########
scripts/change_detector.py:
##########
@@ -55,6 +55,11 @@
],
"frontend": [
r"^\.github/workflows/.*(bashlib|frontend|e2e)",
+ # The composite actions every Playwright job calls
(cached-dependencies,
+ # setup-backend, change-detector). A change to the setup they share can
+ # break those jobs while touching nothing under superset-frontend/, so
+ # it has to reach them.
+ r"^\.github/actions/",
Review Comment:
Good catch — `setup-backend` is a backend action, and gating it on
`"frontend"` alone meant a PR touching only `.github/actions/setup-backend/`
set `frontend=true`, `python=false`, and skipped the Python jobs whose own
setup had changed.
Fixed in 50d2bf7b7d: the pattern is now in both groups, and the comment no
longer claims these are only the Playwright jobs' setup.
```
.github/actions/setup-backend/action.yml -> python=True frontend=True
.github/actions/cached-dependencies -> python=True frontend=True
```
The test is parametrized over both groups rather than asserting only
`frontend`, so the same gap can't reopen on one side:
```python
@pytest.mark.parametrize("group", ["frontend", "python"])
def test_composite_action_changes_trigger_tests(group: str) -> None:
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
