gabotorresruiz commented on code in PR #44573:
URL: https://github.com/apache/superset/pull/44573#discussion_r4160520312
##########
superset/mcp_service/dataset/schemas.py:
##########
@@ -627,7 +628,7 @@ class MetricCurrency(BaseModel):
)
-class DatasetMetricProperties(BaseModel):
+class DatasetMetricProperties(OmittedMeansUnchanged):
Review Comment:
Tiny nit, and only because I was the one who asked for the summary change.
The master merge brought `create_dataset_metric` in, and because it shares
`DatasetMetricProperties` it drops its advertised null defaults too: 9 at the
merge base, 0 at `f65c748`. The summary names `generate_chart`,
`generate_explore_link`, `update_chart_preview` and `get_chart_type_schema` but
not this one. Worth a clause, or leave it, nobody is going to be surprised by a
create tool advertising fewer defaults.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
