tien238lnd commented on code in PR #44573:
URL: https://github.com/apache/superset/pull/44573#discussion_r4164191296
##########
superset/mcp_service/dataset/schemas.py:
##########
@@ -627,7 +628,7 @@ class MetricCurrency(BaseModel):
)
-class DatasetMetricProperties(BaseModel):
+class DatasetMetricProperties(OmittedMeansUnchanged):
Review Comment:
Taken — the summary now names `create_dataset_metric` and says why it is in
the list (it inherits `DatasetMetricProperties`). Also dropped the "chart
config models" framing, since the shared models are no longer only the chart
ones.
_🤖 Addressed by [Claude Code](https://claude.com/claude-code)_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
