bito-code-review[bot] commented on code in PR #43232:
URL: https://github.com/apache/superset/pull/43232#discussion_r4164615562
##########
tests/unit_tests/charts/commands/importers/v1/utils_test.py:
##########
@@ -281,3 +285,24 @@ def test_migrate_chart_table_migrates_when_flag_enabled(
assert new_config["viz_type"] == "ag-grid-table"
assert json.loads(new_config["params"])["viz_type"] == "ag-grid-table"
+
+
+def test_get_dependency_chart_uuids_uses_selection_file() -> None:
+ """Charts missing from the selection file are dependencies."""
+ configs = [{"uuid": "a"}, {"uuid": "b"}, {"uuid": "c"}]
Review Comment:
<!-- Bito Reply -->
The `/resolve` command is not supported on inline comments. Please use it in
a top-level comment instead.
##########
superset/commands/importers/v1/utils.py:
##########
@@ -192,6 +192,7 @@ def load_configs(
if not content:
continue
+ config: Any = None
Review Comment:
<!-- Bito Reply -->
The reviewer's suggestion to use `dict[str, Any] | None` is intended to
improve static type checking by allowing mypy to validate the schema branch and
the `isinstance(config, dict)` guard. While using `Any` avoids potential type
errors when loading YAML, it does bypass static analysis for subsequent
`config` access. If the current implementation relies on the flexibility of
`Any` to handle both scalars and lists, you may choose to keep it, but
annotating the type more specifically is generally preferred to maintain type
safety.
**superset/commands/importers/v1/utils.py**
```
config: Any = None
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
