EnxDev commented on code in PR #43232:
URL: https://github.com/apache/superset/pull/43232#discussion_r4164613849
##########
superset/commands/importers/v1/utils.py:
##########
@@ -192,6 +192,7 @@ def load_configs(
if not content:
continue
+ config: Any = None
Review Comment:
Fair enough, b27b7ae types it as `dict[str, Any] | None`. mypy is happy with
it. Resolving.
##########
tests/unit_tests/charts/commands/importers/v1/utils_test.py:
##########
@@ -281,3 +285,24 @@ def test_migrate_chart_table_migrates_when_flag_enabled(
assert new_config["viz_type"] == "ag-grid-table"
assert json.loads(new_config["params"])["viz_type"] == "ag-grid-table"
+
+
+def test_get_dependency_chart_uuids_uses_selection_file() -> None:
+ """Charts missing from the selection file are dependencies."""
+ configs = [{"uuid": "a"}, {"uuid": "b"}, {"uuid": "c"}]
Review Comment:
Added in b27b7ae. Resolving.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
