justinpark opened a new pull request, #44898: URL: https://github.com/apache/superset/pull/44898
### SUMMARY WebDriverSelenium.create() only read a top-level `binary_location` from WEBDRIVER_CONFIGURATION, but the default config (and the docs) put it under "options". The nested value was never read, so a configured browser path was silently ignored and selenium-manager picked (and could download) a browser itself. Read the nested value too. A top-level value keeps working and takes precedence; an empty or missing value still leaves the browser auto-detected. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF N/A ### TESTING INSTRUCTIONS specs ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
