codeant-ai-for-open-source[bot] commented on code in PR #44898:
URL: https://github.com/apache/superset/pull/44898#discussion_r4167604557
##########
superset/utils/webdriver.py:
##########
@@ -481,9 +481,18 @@ def create(self) -> WebDriver:
webdriver_config = self._normalize_timeout_values(webdriver_config)
kwargs.update(webdriver_config)
- # Set the binary location if provided
+ # Set the binary location if provided, either at the top level or
nested
+ # under "options" (which is where the default config documents it).
# We need to pop it from the dict due to selenium_version < 4.10.0
- options.binary_location = webdriver_config.pop("binary_location", "")
+ nested_options = webdriver_config.get("options")
+ nested_binary_location = (
+ nested_options.get("binary_location")
+ if isinstance(nested_options, dict)
+ else None
+ )
+ options.binary_location = (
+ webdriver_config.pop("binary_location", "") or
nested_binary_location or ""
+ )
Review Comment:
**Suggestion:** Because `kwargs` was updated earlier, popping from
`webdriver_config` does not remove `binary_location` from `kwargs`; Selenium
4.10+ then rejects the unexpected constructor argument.
**Assessment:** ๐ `Major` ยท ๐ `Occurrence: Sometimes` ยท ๐ท๏ธ `Api mismatch`
[](https://docs.codeant.ai/cli/resolve-pr-comments-skill)
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=302bafbd68db49af8c80adcd183a52fb&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=302bafbd68db49af8c80adcd183a52fb&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset/utils/webdriver.py
**Line:** 493:495
**Comment:**
*Api Mismatch: Because `kwargs` was updated earlier, popping from
`webdriver_config` does not remove `binary_location` from `kwargs`; Selenium
4.10+ then rejects the unexpected constructor argument.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F44898&comment_hash=3ddcdb5d0e752ff0107cc1dbeb8bd184c0c24859b6f759ba2841e24c5714c1e3&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F44898&comment_hash=3ddcdb5d0e752ff0107cc1dbeb8bd184c0c24859b6f759ba2841e24c5714c1e3&reaction=dislike'>๐</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
