schizophrenicmaniac opened a new pull request, #44933: URL: https://github.com/apache/superset/pull/44933
### SUMMARY The "Open in SQL Lab" button in the Explore "View query" modal footer only checked `metaKey` to decide whether to open SQL Lab in a new window. On Windows and Linux people use Ctrl for that, so Ctrl+click navigated the current tab to SQL Lab instead. The "View in SQL Lab" button in `ViewQuery` already treats `metaKey || ctrlKey` the same way, so this makes the footer button do the same. I also added RTL tests for the footer, which had none: a plain click (navigates in-app), Cmd+click and Ctrl+click (both post to `/sqllab/` in a new window). ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF Still to be added. Visually nothing changes; only what Ctrl+click does. ### TESTING INSTRUCTIONS 1. Open a chart in Explore. 2. Open the chart menu (...) and pick "View query". 3. Hold Ctrl (Cmd on macOS) and click "Open in SQL Lab". SQL Lab should open in a new tab with the query loaded, and the current tab should stay on Explore. 4. Click "Open in SQL Lab" again without a modifier. The current tab should go to SQL Lab. Unit tests: `npx jest src/explore/components/controls/ViewQueryModalFooter.test.tsx` ### ADDITIONAL INFORMATION - [x] Has associated issue: Fixes #44923 - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
