schizophrenicmaniac commented on code in PR #44933:
URL: https://github.com/apache/superset/pull/44933#discussion_r4187796770
##########
superset-frontend/src/explore/components/controls/ViewQueryModalFooter.tsx:
##########
@@ -87,7 +87,7 @@ const ViewQueryModalFooter: FC<ViewQueryModalFooterProps> =
(props: {
</Button>
<Button
buttonStyle="secondary"
- onClick={({ metaKey }) => openSQL(Boolean(metaKey))}
+ onClick={({ metaKey, ctrlKey }) => openSQL(Boolean(metaKey ||
ctrlKey))}
Review Comment:
Good catch, thanks. It was already broken for Cmd+click before this change,
and Ctrl+click just made it reachable for more people. The footer now posts `{
form_data: safeStringify(payload) }`, the same as the datasource menu's "View
in SQL Lab". The Cmd+click and Ctrl+click tests now assert the serialized
form_data.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
