sadpandajoe commented on code in PR #42910:
URL: https://github.com/apache/superset/pull/42910#discussion_r4172963655
##########
superset-frontend/plugins/plugin-chart-echarts/src/Gauge/controlPanel.tsx:
##########
@@ -278,15 +279,26 @@ const config: ControlPanelConfig = {
],
[
{
- name: 'interval_color_indices',
+ name: 'interval_colors',
config: {
- type: 'TextControl',
+ type: 'IntervalColorsControl',
Review Comment:
The old text input was keyboard-editable, but these rows now use a
click-only color-picker trigger with no tab stop or Enter/Space handler, so
keyboard-only users cannot change interval colors. Could the picker expose a
focusable, keyboard-activatable trigger?
##########
superset/translations/messages.pot:
##########
@@ -15385,6 +15450,12 @@ msgstr ""
msgid "Unverified"
msgstr ""
+msgid "Up to"
Review Comment:
The translation check and Python catalog-drift test fail because the removed
`Up to` label still has a catalog entry; the remaining `%s` message also lacks
its format-validation flag. Could these entries be synchronized with the
current labels?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
