rusackas commented on code in PR #42910:
URL: https://github.com/apache/superset/pull/42910#discussion_r4179835973
##########
superset-frontend/plugins/plugin-chart-echarts/src/Bullet/controlPanel.tsx:
##########
@@ -59,6 +62,25 @@ const config: ControlPanelConfig = {
},
},
],
+ [
+ {
+ name: 'range_colors',
+ config: {
+ type: 'BulletRangeColorsControl',
+ label: t('Range colors'),
+ default: [],
+ renderTrigger: true,
+ description: t(
+ 'Optional custom color for each range band, e.g. to match a
brand palette. Bands left unset use the default shading.',
+ ),
Review Comment:
Good catch @sadpandajoe. `range_colors` now sets `resetOnHide: false`, so
the colors survive the temporary hide while the ranges text is retyped. Added a
control-panel test asserting it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
