bito-code-review[bot] commented on PR #44959:
URL: https://github.com/apache/superset/pull/44959#issuecomment-5972984046
<!-- Bito Reply -->
The flagged issue is correct. In the `ControlPopover` component, the
`placement` state is managed via `useState` but is not being updated or mocked
in the test environment, which prevents the popover from correctly responding
to state changes in uncontrolled tests.
To resolve this, you should ensure that the test setup correctly mocks or
provides the necessary state setters, or update the component to handle the
`placement` state more robustly. Since I do not have access to the `setupTest`
helper implementation, I recommend verifying that `setupTest` includes all
required state initializers or that the component's `placement` logic is
correctly initialized in the test environment.
Would you like me to fetch all comments on this PR to validate the rest of
the feedback and implement fixes for them as well?
**superset-frontend/src/explore/components/controls/ControlPopover/ControlPopover.tsx**
```
const [placement, setPlacement] =
React.useState<TooltipPlacement>(initialPlacement);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
