AmoghAtreya commented on code in PR #44959:
URL: https://github.com/apache/superset/pull/44959#discussion_r4187588116
##########
superset-frontend/src/explore/components/controls/ControlPopover/ControlPopover.tsx:
##########
@@ -148,20 +150,24 @@ const ControlPopover: FC<PopoverProps> = ({
if (visible === undefined) {
Review Comment:
Removed that branch rather than inverting it. `onOpenChange` always gets a
boolean, so `visible === undefined` never ran, and calling scroll-lock from the
handler would freeze Explore scroll even when a parent keeps `open={false}`.
The existing `useEffect` already updates scroll from actual `visible`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
