veriiix opened a new pull request, #44966:
URL: https://github.com/apache/superset/pull/44966
### SUMMARY
Treat 0 as a valid contour threshold. Keep zero-bound isobands on the
correct tab, show zero in inputs and labels, and validate threshold ordering.
Fixes #44913.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before: zero thresholds appeared empty or caused an isoband to appear as an
isoline.
After: zero thresholds display correctly and retain the correct contour type.
### TESTING INSTRUCTIONS
Tested the patched components in a local Storybook preview:
- Save and reopen [-1, 0] and [0, 1]: remain isobands with zero visible.
- Enter [0, 0], [0, -1], or [1, 0]: ordering errors appear and Save is
disabled.
- Save an isoline with threshold 0: label shows 0 and Isoline stays selected.
- Clear a required threshold: Save is disabled.
- Formatting and git diff --check pass.
- Lint reports 0 errors and 2 warnings in unchanged code.
### ADDITIONAL INFORMATION
- [x] Has associated issue: #44913
- [ ] Required feature flags:
- [x] Changes UI
- [ ] Includes DB Migration
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
