codeant-ai-for-open-source[bot] commented on code in PR #44966:
URL: https://github.com/apache/superset/pull/44966#discussion_r4177964259
##########
superset-frontend/src/explore/components/controls/ContourControl/ContourOption.tsx:
##########
@@ -49,7 +49,7 @@ const ContourOption = ({
}: ContourOptionProps) => {
const { lowerThreshold, upperThreshold, color, strokeWidth } = contour;
- const isIsoband = upperThreshold;
+ const isIsoband = Boolean(upperThreshold) || upperThreshold === 0;
Review Comment:
**Suggestion:** `upperThreshold: 0` is now displayed and saved as an
isoband, but the DeckGL renderer still treats zero as an isoline, losing the
threshold range.
**Assessment:** ๐ `Major` ยท ๐ `Occurrence: Sometimes` ยท ๐ท๏ธ `Api mismatch`
[](https://docs.codeant.ai/cli/resolve-pr-comments-skill)
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=fb0c988ce3d2409b9869a02d270bf4c7&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=fb0c988ce3d2409b9869a02d270bf4c7&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:**
superset-frontend/src/explore/components/controls/ContourControl/ContourOption.tsx
**Line:** 52:52
**Comment:**
*Api Mismatch: `upperThreshold: 0` is now displayed and saved as an
isoband, but the DeckGL renderer still treats zero as an isoline, losing the
threshold range.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F44966&comment_hash=1239b1b78e11673bd1ff51afe6e0b79a45ed894896c5e04dea1e28e689cc309a&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F44966&comment_hash=1239b1b78e11673bd1ff51afe6e0b79a45ed894896c5e04dea1e28e689cc309a&reaction=dislike'>๐</a>
##########
superset-frontend/src/explore/components/controls/ContourControl/ContourPopoverControl.tsx:
##########
@@ -50,7 +50,10 @@ const isIsoband = (contour: ContourType) => {
if (Object.keys(contour).length < 4) {
return false;
}
- return contour.upperThreshold && contour.lowerThreshold;
+ return (
+ (contour.upperThreshold || contour.upperThreshold === 0) &&
+ (contour.lowerThreshold || contour.lowerThreshold === 0)
+ );
Review Comment:
**Suggestion:** A contour with both thresholds but fewer than four
enumerable fields is shown as an isoband here but opens in the isoline tab,
disagreeing with its displayed option.
**Assessment:** ๐ `Major` ยท ๐ `Occurrence: Sometimes` ยท ๐ท๏ธ `Api mismatch`
[](https://docs.codeant.ai/cli/resolve-pr-comments-skill)
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=7f6604e8c2d94102ad02948e04879565&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=7f6604e8c2d94102ad02948e04879565&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:**
superset-frontend/src/explore/components/controls/ContourControl/ContourPopoverControl.tsx
**Line:** 53:56
**Comment:**
*Api Mismatch: A contour with both thresholds but fewer than four
enumerable fields is shown as an isoband here but opens in the isoline tab,
disagreeing with its displayed option.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F44966&comment_hash=8a2c2f0a9ccbe81df08c027f2961ca68f089c87fb9df7cfb0e1ff356a0881d82&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F44966&comment_hash=8a2c2f0a9ccbe81df08c027f2961ca68f089c87fb9df7cfb0e1ff356a0881d82&reaction=dislike'>๐</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
