aminghadersohi commented on code in PR #43770: URL: https://github.com/apache/superset/pull/43770#discussion_r4178955004
########## docs/admin_docs/configuration/mcp-server.mdx: ########## @@ -1338,6 +1340,78 @@ Disabling a plugin only stops new charts of that type from being created. Existi - **[Security](/developer-docs/extensions/security)** -- Security best practices for extensions - **[Deployment](/developer-docs/extensions/deployment)** -- Package and deploy Superset extensions +## Bullet chart compatibility + +The MCP Bullet plugin uses `chart_type: "bullet"` and the native ECharts +`viz_type: "bullet"`. Its optional `dimensions` hierarchy maps to `groupby`. +Omit `dimensions` (or use `null`) to create a single-metric Bullet without a +breakdown. On updates, omission or `null` preserves the saved hierarchy; use +`dimensions: []` to clear it explicitly. An `order_by` update can reference the +saved dimensions without resending them; unknown targets are rejected after +resolving the saved hierarchy. When replacing the dataset, saved-chart and +cached-preview updates retain an omitted hierarchy only if its columns resolve +in the replacement dataset; incompatible inherited roles and temporal-filter +provenance are discarded. + +Dimension and metric output names are case-sensitive: quoted physical columns +such as `Region` and `region` remain distinct. Reference lookup prefers exact +names and uses case-insensitive matching only when there is a single candidate; +ambiguous references require the exact spelling. Bullet metric strings use +JavaScript numeric spellings: underscore separators and non-ASCII digits are +rejected rather than interpreted as numbers. + +Range, marker, and marker-line label lists may be shorter than their value lists. +As in Explore, missing or empty range labels are not displayed, and missing or +empty marker labels use the formatted numeric value. Extra labels have no value +to annotate and are ignored. These rules also apply to saved-chart previews and +updates; omitted label controls preserve the saved state. Review Comment: Introduced by this PR's documentation; clearing omitted labels when replacing their value controls is intentional. Clarified in 02453fbea4bcb29fe20087f2d08d1ba333f3bbf1: labels are preserved only when the corresponding ranges, markers, or marker_lines control is also omitted; resend labels with replacement values to retain annotations. Extended the regression to verify both preservation and clearing for all three control pairs. Validation: 3,637 chart unit tests passed, 3 skipped; staged pre-commit passed, including mypy and pylint. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
