aminghadersohi commented on code in PR #44950:
URL: https://github.com/apache/superset/pull/44950#discussion_r4179915296
##########
superset/daos/chart.py:
##########
@@ -36,6 +36,7 @@
# Custom filterable fields for charts
CHART_CUSTOM_FIELDS = {
+ "datasource_id": ["eq", "ne", "in", "nin"],
Review Comment:
Fixed in bc1b8f6f8af39e0ee698c5a6a4b146760f2c4ddd. Dataset ID filters
require datasource_type = table in ChartDAO, the shared filter path used by
list_charts. DAO and MCP regression tests cover same-ID semantic-view charts
for eq, ne, in, and nin, verifying they are excluded. Validation: MCP suite
plus chart DAO regressions: 6888 passed, 3 skipped; chart DAO/relationship
tests: 27 passed; pre-commit passed on all branch-touched files.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
